Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misconfigured aria-labelledby for product tabs #21302

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Misconfigured aria-labelledby for product tabs #21302

merged 1 commit into from
Mar 1, 2019

Conversation

Amadeco
Copy link

@Amadeco Amadeco commented Feb 18, 2019 •
edited
Loading

Good afternoon,

I find out attribute aria-labelledby is misconfigured for jquery ui tabs in product page.

It must be declared for content of tab and not title.

Ilan PARMENTIER

Source :
https://www.w3.org/TR/wai-aria-practices/examples/tabs/tabs-1/tabs.html#sc1_label

Misconfigured aria-labelledby for product tabs
27fb560 
Good afternoon,

I find out attribute aria-labelledby is misconfigured.
It must be declared for the content of the tab and not the title, in particular, for a parent tag.

Ilan PARMENTIER

Source : 
https://www.w3.org/TR/wai-aria-practices/examples/tabs/tabs-1/tabs.html#sc1_label
@magento-engcom-team
Copy link
Contributor

Hi @mageho. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Karlasa Karlasa self-assigned this Feb 18, 2019
Karlasa
Karlasa approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@Karlasa Karlasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice finding 👍

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, thank you for the review.
ENGCOM-4312 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 27fb560 into magento:2.3-develop Mar 1, 2019
@ghost
Copy link

ghost commented Mar 1, 2019

Hi @mageho, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Mar 1, 2019
@sidolov
ENGCOM-4312: Misconfigured aria-labelledby for product tabs #21302
732ecd7
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 1, 2019
@amol2jcommerce amol2jcommerce mentioned this pull request Mar 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karlasa Karlasa Karlasa approved these changes

Assignees

@Karlasa Karlasa

Labels
Area: Frontend Component: Catalog Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Amadeco @magento-engcom-team @Karlasa